Re: Problem with pg_dump -n schemaname

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Zoltan Boszormenyi <zb(at)cybertec(dot)at>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>
Subject: Re: Problem with pg_dump -n schemaname
Date: 2007-11-24 20:15:37
Message-ID: 200711242015.lAOKFbD14034@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> The fact that schema ss might not exist is one of the scenarios that
> we need to qualify the primary name in the DROP to protect against.
> It's possible say that "complex" would get mis-resolved as some other
> type "complex" in some other schema, but it doesn't matter since the
> qualified function name will surely not match anything else.
>
> What I think we ought to do is just reset currSchema once, after the
> DROP phase is completed, whether or not any schemas were dropped.
> This will be considerably more bulletproof in partial-restore
> situations.
>
> Will go fix.

OK. I did consider that option but was unsure of the ramifications.
The problem is definitely subtle.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-11-24 20:19:21 Re: backup_label and server start
Previous Message Tom Lane 2007-11-24 20:07:44 Re: Problem with pg_dump -n schemaname

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-11-25 01:40:45 Proposed patch to adjust UNION/CASE/etc type resolution rules
Previous Message Tom Lane 2007-11-24 20:07:44 Re: Problem with pg_dump -n schemaname