Re: Fixes for MONEY type using locale

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: darcy(at)druid(dot)net, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fixes for MONEY type using locale
Date: 2007-11-24 15:28:54
Message-ID: 200711241528.lAOFSs507263@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Patch applied. I will email on this LAST_DIGIT issue separately.

---------------------------------------------------------------------------

Bruce Momjian wrote:
> In looking at the use of the thousands separator in formatting.c and
> psql/print.c, I now see similar problems with the MONEY type, namely
> that if the thousands separator is "" it is set to "," even if the
> decimal separator is ",".
>
> The attached patch fixes this.
>
> I also removed a ssymbol test because ssymbol will never be \0 based on
> the code. Also, what does this do:
>
> if (buf[LAST_DIGIT] == ',')
> buf[LAST_DIGIT] = buf[LAST_PAREN];
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://postgres.enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +

>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2007-11-24 16:16:27 Re: 8.3devel slower than 8.2 under read-only load
Previous Message D'Arcy J.M. Cain 2007-11-24 14:24:41 Re: Fixes for MONEY type using locale

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-11-24 16:27:38 Re: Fixes for MONEY type using locale
Previous Message D'Arcy J.M. Cain 2007-11-24 14:24:41 Re: Fixes for MONEY type using locale