Re: Fix pg_dump dependency on postgres.h

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix pg_dump dependency on postgres.h
Date: 2007-11-21 12:47:35
Message-ID: 20071121124735.GE4918@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > > Huh, I think the point is to be able to build 8.3 at all on certain
> > > Solaris releases. I think it qualifies as a portability fix.
> >
> > (a) it wasn't "to build at all", it was to allow "inline" to be enabled
> > on Sun Studio's compiler, which apparently is too dumb to not generate
> > copies of an unreferenced inline function.
> >
> > (b) portability fix or not, this ain't going into 8.3. It's *far* too
> > invasive for this late stage of the cycle.
>
> Yea, that was my analysis too.

Oh, right, I misremembered that it was only to allow inline.

--
Alvaro Herrera http://www.amazon.com/gp/registry/DXLWNGRJD34J
"En las profundidades de nuestro inconsciente hay una obsesiva necesidad
de un universo lógico y coherente. Pero el universo real se halla siempre
un paso más allá de la lógica" (Irulan)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-11-21 13:07:48 Re: VACUUM/ANALYZE counting of in-doubt tuples
Previous Message Peter Eisentraut 2007-11-21 12:20:07 Re: [GENERAL] possible to create multivalued index from xpath() results in 8.3?

Browse pgsql-patches by date

  From Date Subject
Next Message CN 2007-11-21 13:15:21 BUG #3770: Follow up: Fail to make bcc32.mak for libpq
Previous Message Bruce Momjian 2007-11-21 03:08:16 Re: Fix pg_dump dependency on postgres.h