Re: pgsql: Adjust script to be consistent (thanks Tom for the fix).

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgsql: Adjust script to be consistent (thanks Tom for the fix).
Date: 2007-11-13 04:27:45
Message-ID: 200711130427.lAD4Rjs07233@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> Pray tell, why do you think it's a good idea to not have version labels
> >> in the contrib scripts?
>
> > If we want them, they should be in all of them.
>
> +1 for putting the label in all of them --- these files end up "loose"
> in user installations, so having a clear version identity on them seems
> like a Real Good Idea.
>
> > I am worried slightly
> > that a version label will make the SET search_path harder to find, though.
>
> The documentation already says "first command", and there is already
> one comment in front of that. I don't think having two comments in
> front of it will deter anyone smart enough to be installing contrib
> modules into nonstandard schemas.

Agreed. Done.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-11-13 06:29:04 pgsql: Fix a few contrib regression test scripts that hadn't gotten the
Previous Message Bruce Momjian 2007-11-13 04:27:26 pgsql: Adjust expected file for new CVS version label.

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2007-11-13 04:57:02 Re: How to keep a table in memory?
Previous Message Bruce Momjian 2007-11-13 04:03:11 Re: Simplifying Text Search