Re: Avoid needless copy in nodeMaterial

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Avoid needless copy in nodeMaterial
Date: 2007-11-04 22:36:48
Message-ID: 200711042236.lA4MamY05599@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


This has been saved for the 8.4 release:

http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

Neil Conway wrote:
> Attached is a patch that avoids a needless copy of the result tuple in
> nodeMaterial, in the case that we don't have a previously-materialized
> tuple to return. We can just return the TTS produced by executing our
> child node, rather than returning a copy of it.
>
> I didn't bother pulling the MinimalTuple out of "outerslot" and stuffing
> it back into the nodeMaterial's result slot, as AFAICS that is not
> necessary. Although I suppose you could make a cleanliness argument that
> that would be worth doing instead.
>
> (This is 8.4 material...)
>
> -Neil
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
>
> http://www.postgresql.org/about/donate

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Greg Sabino Mullane 2007-11-05 01:11:53 Consistent \d commands in psql
Previous Message Bruce Momjian 2007-11-04 22:32:48 Re: [HACKERS] quote_literal with NULL