Re: Minor change to pg_dump docs

Chris Browne wrote:
> As suggested to me by Ian Darwin <ian(at)darwinsys(dot)com>...
>
> Index: doc/src/sgml/ref/pg_dump.sgml
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/pg_dump.sgml,v
> retrieving revision 1.97
> diff -c -u -r1.97 pg_dump.sgml
> --- doc/src/sgml/ref/pg_dump.sgml 26 Mar 2007 17:23:36 -0000 1.97
> +++ doc/src/sgml/ref/pg_dump.sgml 25 Oct 2007 20:30:10 -0000
> @@ -207,7 +207,8 @@
> (<replaceable>column</replaceable>, ...) VALUES
> ...</literal>). This will make restoration very slow; it is mainly
> useful for making dumps that can be loaded into
> - non-<productname>PostgreSQL</productname> databases.
> + non-<productname>PostgreSQL</productname> databases, or for making
> + dumps that require manual editing.
> Also, since this option generates a separate command for each row,
> an error in reloading a row causes only that row to be lost rather
> than the entire table contents.

In looking at this patch, it is marking the --attribute-inserts option
as one that is best for manual editing. However, isn't text COPY output
also good for manual editing? I am unclear why only --attribute-inserts
should get this text addition. I assume --inserts would also apply. Am
I missing something?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +