Re: Autovacuum cancellation

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Autovacuum cancellation
Date: 2007-10-26 20:50:31
Message-ID: 20071026205031.GD6725@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Tom Lane wrote:
> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> > I assume the right thing happens if multiple deadlock check signals fire for
> > the same autovacuum?
>
> Multiple signals shouldn't be a problem, but late-arriving ones could be.
> It might be worth having autovac explicitly clear QueryCancelPending
> after it's finished a table, so that a SIGINT sent because of activity
> on one table couldn't force cancellation of vacuum on the next one.

Ok, committed; I snuck that in as well, but I'm not sure how to test
that it works.

I adjusted the comments -- I think they're more correct now. I also
added a puny paragraph to lmgr/README.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2007-10-26 21:50:10 pgsql: Change win32 child-death tracking code to use a threadpool to
Previous Message User Dpage 2007-10-26 20:48:59 pginstaller - pginst: Couple o' minor fixes.

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2007-10-26 20:52:01 Re: win32 threads patch vs beta2 - what to do?
Previous Message Alvaro Herrera 2007-10-26 20:45:10 pgsql: Allow an autovacuum worker to be interrupted automatically when

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-10-27 16:09:14 Re: Minor change to pg_dump docs
Previous Message Tom Lane 2007-10-26 14:19:22 Re: Fix ecpg dependency on postgres.h