Re: pgsql: Rearrange vacuum-related bits in PGPROC as a bitmask, to better

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Rearrange vacuum-related bits in PGPROC as a bitmask, to better
Date: 2007-10-24 22:54:13
Message-ID: 20071024225413.GB4626@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> > Rearrange vacuum-related bits in PGPROC as a bitmask, to better support
> > having several of them. Add two more flags: whether the process is
> > executing an ANALYZE, and whether a vacuum is for Xid wraparound (which
> > is obviously only set by autovacuum).
>
> Is the explicit reset of PROC_VACUUM_FOR_WRAPAROUND (about line 2140
> of autovacuum.c) actually needed?

Probably not. Actually I was just wondering if it was possible to
commit the transaction opened for the previous vacuum sooner, which
would clear that bit and also release the locks on the vacuumed
relation. But that's probably too much of a hassle and a wasted Xid or
two.

--
Alvaro Herrera http://www.advogato.org/person/alvherre
"Ellos andaban todos desnudos como su madre los parió, y también las mujeres,
aunque no vi más que una, harto moza, y todos los que yo vi eran todos
mancebos, que ninguno vi de edad de más de XXX años" (Cristóbal Colón)

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-10-24 22:55:52 pgsql: Remove obsolete statement that you can't update through a cursor.
Previous Message Tom Lane 2007-10-24 21:51:52 Re: pgsql: Rearrange vacuum-related bits in PGPROC as a bitmask, to better