Re: Skytools committed without hackers discussion/review

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Skytools committed without hackers discussion/review
Date: 2007-10-10 16:23:49
Message-ID: 20071010162349.GF18791@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Oct 10, 2007 at 11:47:15AM -0400, Tom Lane wrote:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> > IMHO the core operations are already as stable as PostgreSQL use
> > of MVCC, as the module just exports backend internal state...
>
> Well, it exports backend internal state that did not exist before 8.2
> (ie, XID epoch). So it doesn't seem all that set in stone to me.
>
> > Another thing can can be done is more compact representation for
> > txid_snapshot type, but that also won't affect core operation.
>
> That's another thing that's likely to become very much harder to change
> once it's in core. People keep threatening to produce a working
> in-place-upgrade process, and once that's reality the on-disk
> representation of core types is going to be hard to change.

Well, if that is a concern, than it's an equally big concern to have it in
contrib. If people start using it, they're not going to care about us
saying "hey, it was in contrib, why did you use it", when we earlier said
"in order do use our whiz-bang stuff, you must install from contrib". We'll
have complaints that it's too hard to install, but we won't manage to
escape from the responsibility to keep it working.

//Magnus

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-10-10 16:35:32 Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as
Previous Message Tom Lane 2007-10-10 16:18:55 Re: Skytools committed without hackers discussion/review

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2007-10-10 16:24:59 Re: quote_literal with NULL
Previous Message Tom Lane 2007-10-10 16:18:55 Re: Skytools committed without hackers discussion/review