Re: [HACKERS] Add function for quote_qualified_identifier?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [HACKERS] Add function for quote_qualified_identifier?
Date: 2007-10-08 18:33:53
Message-ID: 200710081833.l98IXru16653@momjian.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackerspgsql-patches

Brendan Jurd wrote:
> On 9/29/07, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > I think we need more than one person's request to add this function.
>
> Well, I don't expect it would get requested. Most DBAs would likely
> look for the function in the docs, see it's not there and then just
> implement it themselves. Obviously it's not critical. But
> anticipating those little requirements and providing for them is one
> of the things that makes a piece of software a pleasure to use.
> "Batteries included" and all that.

I was just looking for someone else to say "Yea, I would like that too".

> Anyway, I seem to be flogging a horse which, if not dead, is surely
> mortally wounded. If quote_qualified_ident isn't desired, perhaps you
> can still use the regression test I included for quote_ident in the
> patch. The test is functional as a standalone item, and seems to fill
> a gap.

Well, we don't test everything and I don't remember problems in quoting
in the past, at least not enough to add another test.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-10-08 18:43:07 Re: Getting to 8.3 beta1
Previous Message Tom Lane 2007-10-08 17:34:29 Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2007-10-08 19:47:14 txid strtoull fix
Previous Message Heikki Linnakangas 2007-10-08 17:10:45 Re: Including Snapshot Info with Indexes