Re: initdb of regression test failed.

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: initdb of regression test failed.
Date: 2007-10-04 02:43:29
Message-ID: 20071004110719.BD0A.ITAGAKI.TAKAHIRO@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


"Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> wrote:

> regression test surely goes wrong.!

This fix does nothing against the regression failure.

It is probably reasonable to choose UTF-8 as a server encoding when we cannot
support the encoding of the current locale. A remaining issue is which we
should use no-locale, locale of another encoding, or reporting error then.

At least on Windows, locale of another encoding works correctly because
we've already had some Windows-specific hacks. (try grep MultiByteToWideChar)
In fact, we can accept options like:
initdb -E UTF8 --locale=Japanese_Japan.932 -- CP932 is SJIS in nature

I'll suggest to use UTF8 if the encoding is UTF-8 or NOT specified and
we don't support the locale encoding on Windows, i.e. locale is always
enabled on regression tests.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2007-10-04 04:22:34 Re: initdb of regression test failed.
Previous Message Hiroshi Saito 2007-10-04 02:28:57 Re: initdb of regression test failed.