Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice
Date: 2007-09-27 05:41:19
Message-ID: 200709270541.l8R5fJI27959@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches


I just talked to Teodor and we discussed this problem. My idea is to
have a special marker in the synonym table, perhaps "*" to indicate the
presence of _any_ stop word at that location. This will not produce any
warnings because it is clearly intentional. The original warning for a
literal stop word will remain but will happen only when the user users
an actual unintentional use of a stop word. The synonym examples will
need to be updated to use "*" as stop word markers.

---------------------------------------------------------------------------

Tom Lane wrote:
> Log Message:
> -----------
> Temporarily modify tsearch regression tests to suppress notice that comes
> out at erratic times, because it is creating a totally unacceptable level
> of noise in our buildfarm results. This patch can be reverted when and if
> the code is fixed to not issue notices during cache reload events.
>
> Modified Files:
> --------------
> pgsql/src/backend/tsearch:
> thesaurus_sample.ths (r1.1 -> r1.2)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/thesaurus_sample.ths?r1=1.1&r2=1.2)
> pgsql/src/test/regress/expected:
> tsdicts.out (r1.1 -> r1.2)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/tsdicts.out?r1=1.1&r2=1.2)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-09-27 05:49:52 Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice
Previous Message User Eggyknap 2007-09-27 02:50:50 pllolcode - pllolcode: Using plproxy as a guide (thanks, DarcyB, for the

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-09-27 05:41:51 Re: little PITR annoyance
Previous Message Bruce Momjian 2007-09-27 05:23:07 Re: Minor changes to Recovery related code

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-27 05:49:52 Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice
Previous Message Bruce Momjian 2007-09-27 05:23:07 Re: Minor changes to Recovery related code