Re: change name of redirect_stderr?

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: change name of redirect_stderr?
Date: 2007-08-14 16:26:01
Message-ID: 20070814162601.GE9206@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Alvaro Herrera wrote:
> > Bruce Momjian wrote:
> > > Andrew Dunstan wrote:
> > > >
> > > > >> I suggest "redirect_logs", although it's arguably too general as it
> > > > >> doesn't apply to syslog/eventlog.
> > > > >
> > > > > Perhaps it should be named analogously to stats_start_collector,
> > > > > ie think of the syslogger process as a "log collector". I don't
> > > > > much like "log_start_collector" though --- "start_log_collector"
> > > > > seems far less confusing as to where the verb is.
> > > >
> > > > Nobody else seems to care much. I'll go with "start_log_collector".
> > >
> > > Are we trying to use log_* prefixes, e.g. log_start_collector?
> >
> > That sounds like you want to log when the collector starts, which is not
> > the case and is confusing -- what collector is it talking about? This
> > is about starting the log collector.
>
> Yea, good point. I was just wondering because I don't see 'start' used
> in anywhere at the beginning of a GUC variable.

Good point too. In other places we just name the feature that's to be
started, for example we don't use "start_autovacuum".

--
Alvaro Herrera http://www.flickr.com/photos/alvherre/
"Granting software the freedom to evolve guarantees only different results,
not better ones." (Zygo Blaxell)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-08-14 16:29:24 Re: Testing the async-commit patch
Previous Message Simon Riggs 2007-08-14 16:22:52 Re: Testing the async-commit patch