pgsql: Fix a gradual memory leak in ExecReScanAgg().

From: neilc(at)postgresql(dot)org (Neil Conway)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix a gradual memory leak in ExecReScanAgg().
Date: 2007-08-08 18:07:05
Message-ID: 20070808180705.A25D39FB787@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
hash table is allocated in a child context of the agg node's memory
context, MemoryContextReset() will reset but *not* delete the child
context. Since ExecReScanAgg() proceeds to build a new hash table
from scratch (in a new sub-context), this results in leaking the
header for the previous memory context. Therefore, use
MemoryContextResetAndDeleteChildren() instead.

Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating
the cause of the leak.

Modified Files:
--------------
pgsql/src/backend/executor:
nodeAgg.c (r1.152 -> r1.153)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeAgg.c.diff?r1=1.152&r2=1.153)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-08-09 01:18:43 pgsql: Revise postmaster startup/shutdown logic to eliminate the problem
Previous Message Neil Conway 2007-08-08 18:07:03 pgsql: Fix a gradual memory leak in ExecReScanAgg().