From: | neilc(at)postgresql(dot)org (Neil Conway) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix a gradual memory leak in ExecReScanAgg(). |
Date: | 2007-08-08 18:06:55 |
Message-ID: | 20070808180655.F28499FB71C@postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
hash table is allocated in a child context of the agg node's memory
context, MemoryContextReset() will reset but *not* delete the child
context. Since ExecReScanAgg() proceeds to build a new hash table
from scratch (in a new sub-context), this results in leaking the
header for the previous memory context. Therefore, use
MemoryContextResetAndDeleteChildren() instead.
Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating
the cause of the leak.
Tags:
----
REL7_4_STABLE
Modified Files:
--------------
pgsql/src/backend/executor:
nodeAgg.c (r1.116.2.3 -> r1.116.2.4)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeAgg.c.diff?r1=1.116.2.3&r2=1.116.2.4)
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2007-08-08 18:06:58 | pgsql: Fix a gradual memory leak in ExecReScanAgg(). |
Previous Message | Tom Lane | 2007-08-08 16:00:47 | pgsql: Fix thinko in multi-autovac-workers code: validity checks made by |