Re: allow CSV quote in NULL

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: allow CSV quote in NULL
Date: 2007-07-27 05:03:27
Message-ID: 20070727050327.GI4887@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > Please find attached a minor patch to remove the constraints that a
> > user can't include the delimiter or quote characters in a 'NULL AS'
> > string when importing CSV files.
>
> This can't really be sane can it?

hm? It's a problem I've run into a number of times and I finally got
fed up with it enough to create a patch for it. It solves my problem
and I don't believe breaks or adversely affects anything else. It also
has to be explicitly asked for by the user, and when the user asks for
it, what's done is intuitively what would be expected.

I don't see the logic in forbidding the user from being able to do
this... My specific case involved an integer field which was quoted in
the CSV file (which isn't generally a problem, it's only an issue if it
ends up being a an empty string). I could easily see it being used for
text fields as well though, if, for example, they want empty strings,
even when quoted, to import as NULLs. Of course, the default remains
that it'd be imported as an empty string, having it be a NULL has to be
explicitly requested.

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2007-07-27 06:10:42 Re: Updated tsearch documentation
Previous Message Stephen Frost 2007-07-27 04:53:11 Re: Building CVS problem?

Browse pgsql-patches by date

  From Date Subject
Next Message Gregory Stark 2007-07-27 09:22:42 Re: allow CSV quote in NULL
Previous Message Tom Lane 2007-07-27 04:51:56 Re: allow CSV quote in NULL