Re: plperl warnings on win32

On Tue, Jul 24, 2007 at 10:11:52AM -0400, Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
> >On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote:
> >
> >>Magnus Hagander <magnus(at)hagander(dot)net> writes:
> >>
> >>> override CPPFLAGS += -DPLPERL_HAVE_UID_GID
> >>>+ # Perl on win32 contains /* within comment all over the header file,
> >>>+ # so disable this warning.
> >>>+ override CFLAGS += -Wno-comment
> >>> endif
> >>>
> >>If you insist you can apply that in some way that makes it Windows-only.
> >>I object strongly to the patch in this form, because it will mask our
> >>own mistakes as well as one particular Perl build's mistakes.
> >>
> >
> >Uh, it's already inside a win32-only block. So it'll only affect mingw.
> >
> >Do you know of a way to do it from inside gcc, like the #pragma that exists
> >for win32 to disable specific warnings? If so we could just disable it on
> >the line before we #include the perl header, and re-enable it after...
> >
>
> see
>
> http://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html#Diagnostic-Pragmas

This seems to be new in gcc 4.2, so we can't really use that :(

//Magnus