Kerberos warnings on win32

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Kerberos warnings on win32
Date: 2007-07-24 10:33:39
Message-ID: 20070724103339.GA19199@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

When building with Kerberos support (or GSSAPI, but not SSPI) on Win32, a
whole bunch of warnings come out due to redefinitions of macros in the
kerberos headers. The reason for this is that Kerberos leaks the
HAVE_<something> macros from autoconf into the header files that are
included by PostgreSQL.

The attached file removes this by undefing the macros before we include the
kerberos files. But this is perhaps just too ugly to deal with and we
should live with the warnings instead?

For MSVC, we can suppress the warnings with a #pragma around the include,
but I don't know if that's possible in mingw/gcc. It'll look something likt
the second patch attached (only did that for one of the places that'd need
it, to show what it looks like)

Thoughts? Worth doing anything about?

//Magnus

Attachment Content-Type Size
krb_defs.diff text/plain 3.4 KB
krb_defs_msvc.diff text/plain 731 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2007-07-24 11:24:32 DLLIMPORT definition
Previous Message Simon Riggs 2007-07-24 10:00:58 Re: avoiding WAL logging in 8.3