Re: pgsql: Document that age() adds days, then full months.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Document that age() adds days, then full months.
Date: 2007-07-18 22:33:38
Message-ID: 200707182233.l6IMXcq27422@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Document that age() adds days, then full months.
>
> AFAICT, this documentation "improvement" is outright wrong.

I am now thinking no documentation paragraph is even needed. We have to
use the number of months in the earlier date or simple computations
would not work like:

test=> select age('2004-05-29', '2004-06-28');
age
----------
-30 days
(1 row)

The end of the earlier month is part of the interval between the two
timestamps, while the end of the later month is not. Of course with a
multi-months span there are more chances for variance, but we certainly
should give the right answer for an interval < 1 month. I can just add
a C comment.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-07-19 17:15:30 pgsql: Adjust configure script to print the bison and flex versions in
Previous Message Tom Lane 2007-07-18 21:41:22 pgsql: Fix an old thinko in SS_make_initplan_from_plan, which is used