From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: IsTransactionState() is being used incorrectly |
Date: | 2007-07-17 01:54:50 |
Message-ID: | 200707170154.l6H1so219952@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Is this done or should it be kept for 8.4?
---------------------------------------------------------------------------
Tom Lane wrote:
> I just noticed that there are a number of places (mostly GUC assignment
> hooks) that use IsTransactionState() to decide if it's safe for them to
> do catalog lookups. This seems pretty bogus because IsTransactionState
> will return true in an aborted transaction. I'm not sure there's any
> actual bug because of other constraints on when GUC updates occur, but
> it sure looks like trouble waiting to happen.
>
> We could fix this either by changing the definition of
> IsTransactionState() or by introducing another test function with
> a different name. Any thoughts which is preferable?
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-07-17 01:56:58 | Re: IsTransactionState() is being used incorrectly |
Previous Message | Bruce Momjian | 2007-07-17 01:52:55 | Re: "Working with CVS" documentation |