Re: pgsql: Add support for GSSAPI authentication.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add support for GSSAPI authentication.
Date: 2007-07-11 08:31:57
Message-ID: 20070711083157.GA21937@svr2.hagander.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Jul 10, 2007 at 02:26:26PM -0400, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Anyway. I can live with having it as a DEBUG message, and will change it
> > to that. What level of debug do you think is reasonable?
>
> I'd go with DEBUG2 or so for messages that might be significant to
> someone wondering "why can't Joe log in?", and 3 or 4 for messages
> that would only be interesting to someone trying to debug the code.
>
> Of the two messages at issue here, I think the first one is at the lower
> level, if needed at all, because it's purely a progress message.
> If you're going to log the username at the point where you decide it's
> bad, then there's no need to log it when you get it.

I've applied the fixes.

I had already removed the progress message because as you say, when you
really need it you get it in the error message.

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Pgunittest 2007-07-11 14:35:52 pgunittest - pgUnitTest:
Previous Message Magnus Hagander 2007-07-11 08:27:33 pgsql: A bunch of GSSAPI fixes per comments from Tom: * use elog not