Style of file error messages

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Style of file error messages
Date: 2007-05-30 16:18:02
Message-ID: 200705301818.02837.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Just to get an opinion, which is better:

could not open transaction log file "%s": %m
could not open control file "%s": %m
could not open data file "%s": %m
could not open temporary file "%s": %m
could not open whatever file "%s": %m

or just:

could not open file "%s": %m

It seems to me that by the time you get to a file error message of this
level, the higher-level purpose of the file is pretty irrelevant.
(Specific exceptions might exist.) Log analysis tools might also
prefer a uniform format.

Anyway, some consistency either way would be nice.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-05-30 16:27:22 Re: 'Waiting on lock'
Previous Message Zeugswetter Andreas ADI SD 2007-05-30 16:10:28 Re: TOAST usage setting