From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | NikhilS <nikkhils(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, Trevor Hardcastle <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
Date: | 2007-05-29 00:35:34 |
Message-ID: | 200705290035.l4T0ZYR21072@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
OK, so the patch is ready to be applied?
---------------------------------------------------------------------------
NikhilS wrote:
> Hi,
>
> > I agree this will unnecessary add arguments to the DefineIndex API. If we
> > > stick to the patch's earlier way of converting the Oid to names for just
> > > these 2 arguments, we can avoid this IMO.
> > >
> > > Considering that we will be generating this information from existing
> > valid
> > > index information, I think converting the Oids to names is safe enough.
> > > Alvaro, do you think we should stick to the existing patch mechanism
> > then
> > > considering that it avoids polluting the API?
> >
> > Not sure. Is it possible that the schema is renamed while the operation
> > is being executed? If it's not then this not a problem at all so the
> > existing patch is fine.
>
>
> I doubt if accessMethod name will change. The tableSpace name can change,
> but the possibility is no worse to doing a [CREATE TABLE table_name ...
> TABLESPACE tablespace]. So this should be reasonably ok.
>
> Regards,
> Nikhils
> --
> EnterpriseDB http://www.enterprisedb.com
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Chris Browne | 2007-05-29 01:40:57 | Re: TOAST usage setting |
Previous Message | Tatsuo Ishii | 2007-05-29 00:19:18 | Re: What is the maximum encoding-conversion growth rate, anyway? |
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2007-05-29 01:50:47 | Re: Seq scans status update |
Previous Message | Tom Lane | 2007-05-28 22:16:13 | Re: Seq scans status update |