From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | NikhilS <nikkhils(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, Trevor Hardcastle <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
Date: | 2007-05-23 14:24:42 |
Message-ID: | 20070523142442.GL4642@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
NikhilS escribió:
> On 5/23/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> >NikhilS <nikkhils(at)gmail(dot)com> writes:
> >> If so, I think we can introduce 2 Oid fields in the IndexStmt
> >> structure and store the Oids there. In DefineIndex we can use these
> >> Oids if they are not invalid.
> >
> >I think this is just make-work that causes the patch to complicate parts
> >of the system it didn't need to touch. The original suggestion was to
> >actively refactor existing code, which might or might not have been
> >worthwhile. But this isn't an appropriate substitute --- it's just
> >making the API uglier for no particular benefit.
>
> I agree this will unnecessary add arguments to the DefineIndex API. If we
> stick to the patch's earlier way of converting the Oid to names for just
> these 2 arguments, we can avoid this IMO.
>
> Considering that we will be generating this information from existing valid
> index information, I think converting the Oids to names is safe enough.
> Alvaro, do you think we should stick to the existing patch mechanism then
> considering that it avoids polluting the API?
Not sure. Is it possible that the schema is renamed while the operation
is being executed? If it's not then this not a problem at all so the
existing patch is fine.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2007-05-23 14:34:06 | Re: like/ilike improvements |
Previous Message | Tom Lane | 2007-05-23 14:11:56 | Re: Re: [Oledb-dev] double precision error with pg linux server, but not with windows pg server |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2007-05-23 14:34:06 | Re: like/ilike improvements |
Previous Message | NikhilS | 2007-05-23 14:08:33 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |