From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Tomas Doran <bobtfish(at)bobtfish(dot)net> |
Cc: | Neil Conway <neilc(at)samurai(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Implemented current_query |
Date: | 2007-05-10 02:09:53 |
Message-ID: | 20070510020953.GC4504@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tomas Doran wrote:
>
> On 7 May 2007, at 23:25, Neil Conway wrote:
>
> >On Mon, 2007-07-05 at 19:48 +0100, Tomas Doran wrote:
> >>As suggested in the TODO list (and as I need the functionality
> >>myself), I have implemented the current_query interface to
> >>debug_query_string.
FWIW I think you should still provide dblink_current_query, even if it's
only a wrapper over current_query(), for backwards compatibility.
Also, typically we don't remove items from the TODO list. We mark them
as "done" prepending them with a dash. Patch authors are not expected
to do it either (though I don't see it be a problem if they did).
> Also done, note OID has changed as I was having conflicts (template1
> wouldn't build). Should I either pick something else unused which is
> lower (is there anything?), move current_query to the end of the file
> or just leave it be..
Doesn't matter ... just make sure duplicate_oids doesn't report a
problem. unused_oids is useful to find, err, unused OIDs.
> >* AFAIK debug_query_string() still does the wrong thing when the user
> >submits multiple queries in a single protocol message (separated by
> >semi-colons). Not sure there's a way to fix that that is both easy and
> >efficient, though...
>
> Should that be added to the TODO list?
Probably ...
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | CK Tan | 2007-05-10 03:52:24 | Re: Seq scans roadmap |
Previous Message | Tomas Doran | 2007-05-10 01:59:56 | Re: Implemented current_query |
From | Date | Subject | |
---|---|---|---|
Next Message | CK Tan | 2007-05-10 03:49:26 | Patch for seq scan & scan resistant bufmgr |
Previous Message | Tomas Doran | 2007-05-10 01:59:56 | Re: Implemented current_query |