| From: | "Magnus Hagander" <magnus(at)hagander(dot)net> |
|---|---|
| To: | itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Clear up strxfrm() in UTF-8 with locale on Windows |
| Date: | 2007-05-07 05:41:45 |
| Message-ID: | 20070507054405.89B7DDCC860@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
> > > So actually an equality test against INT_MAX would be correct. But making
> > > that clear in the comment would probably not be a bad idea :-)
> >
> > I have applied a fix for this, because it obviously needed fixing
> > regardless of if it fixes the original issue all the way. Still looking
> > for confirmation if it does, though.
>
> The fix works well. I tested it with UTF-8 encoding and Japanese_Japan.932
> (SJIS) locale and I didn't see any errors. I think it it is enough to cover
> the buggy UTF-8 treatment on Windows.
>
Thanks for testing.
Bruce, that means the original patch is not needed, so you can take it off the patch queue. Thanks.
/Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-05-07 09:49:13 | Re: Diagnostic functions |
| Previous Message | ITAGAKI Takahiro | 2007-05-07 04:43:05 | Re: autovacuum does not start in HEAD |