pgsql: A few fixups in error handling: mark pg_re_throw() as noreturn

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: A few fixups in error handling: mark pg_re_throw() as noreturn
Date: 2007-05-04 02:01:02
Message-ID: 20070504020102.C0C759FB59E@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
A few fixups in error handling: mark pg_re_throw() as noreturn for gcc,
and for other compilers, insert a dummy exit() call so that they understand
PG_RE_THROW() doesn't return. Insert fflush(stderr) in ExceptionalCondition,
per recent buildfarm evidence that that might not happen automatically on some
platforms. And const-ify ExceptionalCondition's declaration while at it.

Modified Files:
--------------
pgsql/src/backend/utils/error:
assert.c (r1.33 -> r1.34)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/error/assert.c.diff?r1=1.33&r2=1.34)
elog.c (r1.184 -> r1.185)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/error/elog.c.diff?r1=1.184&r2=1.185)
pgsql/src/include:
postgres.h (r1.79 -> r1.80)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/postgres.h.diff?r1=1.79&r2=1.80)
pgsql/src/include/utils:
elog.h (r1.85 -> r1.86)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/elog.h.diff?r1=1.85&r2=1.86)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-05-04 02:06:13 pgsql: Suppress a recently-introduced 'variable might be clobbered by
Previous Message Tom Lane 2007-05-04 01:13:45 pgsql: Teach tuplesort.c about "top N" sorting, in which only the first