Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc
Date: 2007-04-27 02:47:20
Message-ID: 200704270247.l3R2lKE04897@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


Is anyone working on this fix?

---------------------------------------------------------------------------

Tom Lane wrote:
> Log Message:
> -----------
> Remove some of the most blatant brain-fade in the recent guc patch
> (it's so nice to have a buildfarm member that actively rejects naked
> uses of strcasecmp). This coding is still pretty awful, though, since
> it's going to be O(N^2) in the number of guc variables. May I direct
> your attention to bsearch?
>
> Modified Files:
> --------------
> pgsql/src/backend/utils/misc:
> guc.c (r1.387 -> r1.388)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.387&r2=1.388)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-04-27 03:19:15 Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc
Previous Message User H-saito 2007-04-27 01:49:10 psqlodbc - psqlodbc: Prep for 08.02.0400 release.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-04-27 02:57:37 Re: [HACKERS] autovacuum does not start in HEAD
Previous Message Bruce Momjian 2007-04-27 02:45:49 Re: pgsql crollable cursor doesn't support one form of postgresql's cu