| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improving deadlock error messages |
| Date: | 2007-04-23 22:26:47 |
| Message-ID: | 20070423222647.GG12624@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Neil Conway wrote:
> On Mon, 2007-04-23 at 17:38 -0400, Tom Lane wrote:
> > I'm really still opposed to the entire concept. You're proposing to put
> > a lot of fragile-looking code into a seldom-exercised error path.
>
> There's certainly not a "lot" of code: the patch just adds a few
> syscache lookups, wrapped in a PG_LOCK_NOWAIT() block.
>
> As for fragility, I think the important point is whether it's safe to
> siglongjmp() out of LockAcquire(); the rest is just window dressing.
We have some elog(ERROR) calls in LockAcquire, so yes, there are some
siglongjmp calls already in there.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-04-23 23:02:30 | Re: Better error message for select_common_type() |
| Previous Message | Peter Eisentraut | 2007-04-23 22:20:08 | Re: Wild idea: 9.0? |