Re: parser dilemma

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: parser dilemma
Date: 2007-04-19 21:04:49
Message-ID: 20070419210449.GA31116@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Thu, Apr 19, 2007 at 11:19:40AM +0200, Zoltan Boszormenyi wrote:
> >The problem comes from cases like
> >
> > colname coltype DEFAULT 5! GENERATED ...
> >
> >Since b_expr allows postfix operators, it takes one more token of
> >lookahead than we have to tell if the default expression is "5!"
> >or "5!GENERATED ...".

ISTM that as long as:

colname coltype DEFAULT (5!) GENERATED ...

works I don't see why it would be a problem to require the parentheses
in this case. Postfis operators are not going to be that common here I
think.

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gustavo Tonini 2007-04-19 21:38:08 Fragmentation project
Previous Message Florian G. Pflug 2007-04-19 20:37:33 [PATCH] A crash and subsequent recovery of the master can cause the slave to get out-of-sync

Browse pgsql-patches by date

  From Date Subject
Next Message Koichi Suzuki 2007-04-20 06:00:15 Re: [HACKERS] Full page writes improvement, code update
Previous Message Heikki Linnakangas 2007-04-19 13:23:48 Re: HOT Patch - Ready for review