Re: Autovacuum vs statement_timeout

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Jim C(dot) Nasby" <jim(at)nasby(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: Autovacuum vs statement_timeout
Date: 2007-04-18 01:25:34
Message-ID: 20070418012534.GA15869@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Joshua D. Drake wrote:
> Tom Lane wrote:
> >Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> >>I'm with Joshua on this one. Statement_timeout is often used as a means
> >>for protection from long running statements due to server load and
> >>locking and all of the above commands can certainly fall into that area.
> >>If people feel strongly that the command line programs need a way to
> >>circumvent it, add a --ignore-statement-timeout option or similar
> >>mechanism.
> >
> >The worst-case scenario here is that your server fails and you discover
> >that all your backups are corrupt because you didn't notice pg_dump was
> >failing due to statement_timeout. (Maybe it just recently started to
> >fail because your biggest table grew past the point at which the COPY
> >command exceeded statement_timeout.)
> >
> >I'm not excited about the other ones but I can see the argument for
> >making pg_dump force the timeout to 0.
>
> I guess my point is, if you are knowledgeable enough to actually set a
> statement_timeout, you are likely knowledgeable enough to know how to
> turn it off for programs like pg_dump.

I think that is too strong an assumption, which is why I'm planning to
back-patch the change to reset statement_timeout to 0 on autovacuum till
8.0, as discussed. I think I should also backpatch the change to set
zero_damaged_pages as well (which is not on 8.0 AFAIR).

It's very very easy to change things in postgresql.conf. Actually
knowing what you are doing (i.e. thinking on the consequences on VACUUM
and such) is a whole another matter.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-04-18 02:28:45 Re: [COMMITTERS] pgsql: Update error message for COPY with a multi-byte delimiter.
Previous Message Tatsuo Ishii 2007-04-18 01:24:42 Re: utf8 COPY DELIMITER?