Re: autovacuum multiworkers, patch 5

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: autovacuum multiworkers, patch 5
Date: 2007-04-11 23:49:37
Message-ID: 20070411234937.GI8704@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

ITAGAKI Takahiro wrote:
> > > >Yes, that's correct. Per previous discussion, what I actually wanted to
> > > >do was to create a GUC setting to simplify the whole thing, something
> > > >like "autovacuum_max_mb_per_second" or "autovacuum_max_io_per_second".
> > > >Then, have each worker use up to (max_per_second/active workers) as much
> > > >IO resources.
> >
> > One thing I forgot to mention is that this is unlikely to be implemented
> > in 8.3.
>
> This is a WIP cost balancing patch built on autovacuum-multiworkers-5.patch.
> The total cost of workers are adjusted to autovacuum_vacuum_cost_delay.

I manually merged your patch on top of my own. This is the result.
Please have a look at whether the new code is correct and behaves sanely
(I haven't tested it).

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment Content-Type Size
autovacuum-multiworkers-7.patch text/x-diff 24.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Koichi Suzuki 2007-04-12 01:40:04 Re: [HACKERS] Full page writes improvement, code update
Previous Message Tom Lane 2007-04-11 22:56:50 Re: [PATCHES] Fix for large file support

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2007-04-12 00:32:09 High resolution psql \timing on Windows
Previous Message Tom Lane 2007-04-11 22:56:50 Re: [PATCHES] Fix for large file support