Re: [HACKERS] --enable-xml instead of --with-libxml?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Nikolay Samokhvalov <nikolay(at)samokhvalov(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] --enable-xml instead of --with-libxml?
Date: 2007-04-05 01:47:28
Message-ID: 200704050147.l351lSi18429@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


I have applied the following patch which adds documentation and an
improved error message for an installation that does not use
--with-libxml.

---------------------------------------------------------------------------

Nikolay Samokhvalov wrote:
> On 4/5/07, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >
> > Nikolay Samokhvalov wrote:
> > [...]
> > > If I am wrong and it's better to leave libxml2-free capabilities, then
> > IMHO
> > > we need to reflect it explicitly in the docs, what requires libxml2, and
> > > what doesn't
> >
> > Agreed, let's do the later and update the documentation.
>
>
> So, you are agreed that I am wrong :-) Well... I would be happy hear some
> arguments, but I cannot insist on it :-)
>
>
> Also, do we
> > output a helpful message if someone tries to use a libxml2 function that
> > isn't available.
>
>
> Yep, here it is:
>
> INSERT INTO xmltest VALUES (1, '<value>one</value>');
> ERROR: no XML support in this installation
>
> I suppose we should change it to "no libxml2 support in this installation",
> shouldn't we?
>
>
>
> --
> Best regards,
> Nikolay

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-04-05 01:48:08 Re: autovacuum multiworkers, patch 5
Previous Message Andrew - Supernews 2007-04-05 01:35:19 Re: Bug in UTF8-Validation Code?

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-04-05 01:48:08 Re: autovacuum multiworkers, patch 5
Previous Message Gregory Stark 2007-04-05 01:17:00 Re: Auto Partitioning