Skip site navigation (1) Skip section navigation (2)

Bonjour patch

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Chris Campbell <chris(at)bignerdranch(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Bonjour patch
Date: 2007-04-02 20:33:25
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
With no new version from the author and no working version for all
supported OS/X version, I am saving this patch for 8.4.

This has been saved for the 8.4 release:


Chris Campbell wrote:
> On Oct 8, 2006, at 14:29, Tom Lane wrote:
> > Looks good, but I don't think we want to abandon OSX 10.2 support
> > just yet.  I'll revise this to use a configure probe for dlopen.
> Maybe we can abandon Mac OS X 10.2 in 8.3 and later? And not back- 
> port these patches to the 7.x, 8.0, and 8.1 branches?
> BTW, I think the configure probe (only on Darwin, correct?) should  
> test for the existence of <dlfcn.h>.
> > My inclination is to apply this one now, since it only affects OSX
> > and should be easily testable, but to hold off on your other patch
> > for portable Bonjour support until 8.3 devel starts.  The portability
> > implications of that one are unclear, and I don't know how to test it
> > either, so I think putting it in now is too much risk.
> The Bonjour patch wasn't intended to be portable to other platforms  
> just yet. As submitted, it has the same risks/advantages as this  
> dlopen() patch -- it only works on 10.3 and later, but isn't  
> deprecated in 10.4.
> If we want to keep 10.2 support for Bonjour, we can test for both  
> DNSServiceDiscovery.h and dns_sd.h in ./configure, and prefer  
> dns_sd.h if it's found (which will be the case for 10.3 and 10.4) but  
> use DNSServiceDiscovery.h if not (which will be the case for 10.2).
> Thanks!
> - Chris
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

  Bruce Momjian  <bruce(at)momjian(dot)us>

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-04-02 20:33:46
Subject: Re: Is this portable?
Previous:From: Tom LaneDate: 2007-04-02 20:11:35
Subject: Re: Questions about pid file creation code

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-04-02 20:35:47
Subject: Re: Dead Space Map version 3 (simplified)
Previous:From: Tom LaneDate: 2007-04-02 20:23:28
Subject: Re: Current enums patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group