Re: [HACKERS] Arrays of Complex Types

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Arrays of Complex Types
Date: 2007-04-02 20:10:05
Message-ID: 20070402201005.GD29411@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Fri, Mar 30, 2007 at 05:08:42PM -0400, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > After several rounds of patches, it appears that it might be easier to
> > create a new typtype entry, which I'll tentatively call 'a' because it
> > seems a little fragile and a lot inelegant and hard to maintain to
> > have typtype='c' and typrelid=InvalidOid mean, "this is an array of
> > complex types."
>
> Uh, wouldn't it be typtype = 'c' and typelem != 0 ?

Right. The attached patch passes the current regression tests and at
least to a "smoke test" level does what it's supposed to do. I'd
really like to help refactor the whole array system to use 'a', tho.

Cheers,
D
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter

Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate

Attachment Content-Type Size
array_of_complex.diff text/plain 10.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-04-02 20:11:35 Re: Questions about pid file creation code
Previous Message Bruce Momjian 2007-04-02 19:57:40 Re: So are we calling it: Feature Freeze?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-04-02 20:13:23 Re: Concurrent psql v4 [WIP]
Previous Message Bruce Momjian 2007-04-02 20:01:44 Re: [Fwd: Deferred Transactions, Transaction Guarantee and COMMITwithout waiting]