Re: [PATCH] add CLUSTER table USING index

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Holger Schurig <holgerschurig(at)gmx(dot)de>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] add CLUSTER table USING index
Date: 2007-03-28 20:50:43
Message-ID: 20070328205043.GC10878@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

FWIW you don't need to patch the TODO files. They will be updated by
Bruce. (And in any case we don't remove the entries, but rather mark
them with a "-" meaning "done for the next release").

Also, sql_help.h is a generated file. You need to change the appropiate
SGML source (doc/src/sgml/ref/cluster.sgml I think)

> /*
> ! * If we have CLUSTER <sth> ORDER BY, then add the index as well.
> */
> ! else if (pg_strcasecmp(prev3_wd, "CLUSTER") == 0 &&
> ! pg_strcasecmp(prev_wd, "USING") == 0 &&
> ! XXXXX pg_strcasecmp(prev2_wd, "ORDER") == 0)
> {
> ! completion_info_charp = prev3_wd;
> ! COMPLETE_WITH_QUERY(Query_for_index_of_table);
> }

Huh?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Holger Schurig 2007-03-28 20:59:25 Re: [PATCH] add CLUSTER table USING index
Previous Message Holger Schurig 2007-03-28 20:41:12 [PATCH] add CLUSTER table USING index