| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Small code clean-up |
| Date: | 2007-03-28 08:06:15 |
| Message-ID: | 20070328080615.GA11810@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Wed, Mar 28, 2007 at 10:23:09AM +0900, ITAGAKI Takahiro wrote:
> Here are two small code clean-up in initdb and win32_shmem.
>
> pg_char_to_encoding() was redundant in initdb because
> pg_valid_server_encoding() returns the same result if the encoding is valid,
>
> Changes in win32_shmem suppress the following warnings.
> | pg_shmem.c: In function `PGSharedMemoryCreate':
> | pg_shmem.c:137: warning: long unsigned int format, Size arg (arg 2)
> | pg_shmem.c:159: warning: long unsigned int format, Size arg (arg 2)
>
When you send two completely unrelated patches, please send them in
separate emails.
I have applied the win32 shmem part, thanks. Haven't had time to look into
the other one.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2007-03-28 08:36:54 | Re: O_DIRECT support for Windows |
| Previous Message | Andrew - Supernews | 2007-03-28 07:05:24 | Re: Arrays of Complex Types |