| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: We no longer need to palloc the VacuumStmt node; keeping it on |
| Date: | 2007-03-23 21:57:40 |
| Message-ID: | 20070323215740.GE4507@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> > We no longer need to palloc the VacuumStmt node; keeping it on the stack is
> > simpler.
>
> If you're going to do that, you should at least set the nodeTag so that
> the struct appears valid to onlookers. A memset wouldn't be out of
> place either to make sure that any uninitialized fields behave sanely.
Done, thanks.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2007-03-24 14:13:27 | pgsql: Properly parse the name of contrib modules that aren't named the |
| Previous Message | Alvaro Herrera | 2007-03-23 21:57:10 | pgsql: Set the node properly, per Tom. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2007-03-23 22:26:04 | Re: EXISTS optimization |
| Previous Message | Tom Lane | 2007-03-23 21:49:42 | Re: EXISTS optimization |