Re: [HACKERS] Deadlock with pg_dump?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Chris Campbell <chris(at)bignerdranch(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Deadlock with pg_dump?
Date: 2007-03-01 14:06:41
Message-ID: 200703011406.l21E6fe28790@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I have coded up the following patch which places LOG just above ERROR in
> > log_min_error_statement.
>
> LOG_NO_STATEMENT? What *are* you thinking? The kindest word I can find
> for this is "baroque".
>
> What I had in mind was a one-line patch:
>
> if (edata->elevel >= log_min_error_statement && debug_query_string != NULL)
>
> becomes
>
> if (is_log_level_output(edata->elevel, log_min_error_statement) && debug_query_string != NULL)

What are *you* thinking? Yes, that patch has that line, but
log_statement and log_min_duration_statement is going to trigger
log_min_error_statement so you are going to get the statement printed
twice. LOG_NO_STATEMENT fixes that.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-03-01 14:20:13 Re: [PATCHES] WIP Patch - Updateable Cursors
Previous Message Zeugswetter Andreas ADI SD 2007-03-01 14:03:39 Re: Revitalising VACUUM FULL for 8.3

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2007-03-01 14:12:02 Re: Fast COPY after TRUNCATE bug and fix
Previous Message Bruce Momjian 2007-03-01 13:36:39 Re: Fast COPY after TRUNCATE bug and fix