Re: Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: alexey(dot)zayats(at)gmail(dot)com, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"
Date: 2007-02-14 04:30:00
Message-ID: 200702140430.l1E4U0b14854@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > ! if (SOCK_ERRNO != ECONNRESET)
> > ! SSL_shutdown(conn->ssl);
>
> Ummm ... what is this supposed to fix exactly, and what are the odds

I think the user was getting SIGPIPE on SSL_shutdown() of a closed
connection.

> that it will introduce resource leaks?

I don't know myself. If some SSL expert says it is OK, we apply it, if
not, we ignore the patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2007-02-14 04:37:43 Re: Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"
Previous Message Tom Lane 2007-02-14 04:26:23 Re: Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-02-14 04:35:51 Re: Day and month name localization uses wrong locale category
Previous Message Tom Lane 2007-02-14 04:26:23 Re: Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-02-14 04:37:43 Re: Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"
Previous Message Tom Lane 2007-02-14 04:26:23 Re: Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"