From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCHES] [pgsql-patches] Phantom Command IDs, updated patch |
Date: | 2007-02-08 21:14:52 |
Message-ID: | 200702082114.l18LErO17885@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > The way combo cid is supposed to work is that you are deleting a row
> > created in your same transaction by a previous command id, so you look
> > in the combo cid array to see if a match for that pair exists --- if
> > not, you create a new entry and put the two cids on it.
>
> > So, with the combo lock cid, you do the same process, and lookups of who
> > holds the lock looks at the cid combo, and if the second subtransaction
> > was aborted, the first one is the lock holder. If you again lock the
> > row, you create a new combo cid and use the original cid there because
> > the second cid was aborted.
>
> No, because no process other than the originator can see the combo-cid
> data structure, and for locking situations you really need other
> backends to be able to know whether the tuple is locked and how.
Oh, OK, I forgot pg_subtrans is visible to all backends.
> But I think my proposal of extending MultiXact would fix it; please look
> at that.
Sounds good.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-02-08 21:45:40 | Re: better support of out parameters in plperl |
Previous Message | Tom Lane | 2007-02-08 21:10:25 | Re: [PATCHES] [pgsql-patches] Phantom Command IDs, updated patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-02-08 21:45:40 | Re: better support of out parameters in plperl |
Previous Message | Tom Lane | 2007-02-08 21:10:25 | Re: [PATCHES] [pgsql-patches] Phantom Command IDs, updated patch |