From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Jim Nasby <decibel(at)decibel(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Markus Schiltknecht <markus(at)bluegap(dot)ch>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [PATCHES] Fix "database is ready" race condition |
Date: | 2007-02-07 12:41:41 |
Message-ID: | 20070207124141.GI11742@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Jim Nasby wrote:
> On Feb 5, 2007, at 8:19 AM, Tom Lane wrote:
> >"Simon Riggs" <simon(at)2ndquadrant(dot)com> writes:
> >>My suggestions would be
> >>1. "Database system has completed recovery" and
> >>2. "Database system is ready to accept connections"
> >
> >The second was in fact the wording I had in mind, sorry for not being
> >clear. As to the first, the question is whether a log message at
> >that specific point has any use. It's not "completion of recovery",
> >exactly, since we go through that spot whether it's a normal startup
> >or recovery (and there is another log message when we actually do
> >any WAL replay). AFAICS it's a fairly randomly chosen place in a
> >long sequence of Things That Must Happen. Part of the reason Markus
> >is seeing a race condition is that this isn't the last thing done
> >before the startup subprocess exits --- see BootstrapMain. So I'm
> >for just getting rid of it.
>
> It is useful to know if the database had to do recovery, though, and
> if it did do recovery, it would be useful to know how long it took if
> the subsequent startup took a real amount of time.
That's already logged elsewhere, so there's no loss of functionality.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | korryd | 2007-02-07 12:54:42 | Re: Logging functions executed by queries in 8.2? |
Previous Message | Bruce Momjian | 2007-02-07 12:31:42 | Anyone going to the LinuxWorld Summit in NYC |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2007-02-07 13:23:03 | vcbuild needs strlcat |
Previous Message | Peter Eisentraut | 2007-02-07 10:57:21 | Re: BUG #2977: dow doesn't conform to ISO-8601 |