pgsql: Fix an error in the original coding of holdable cursors:

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix an error in the original coding of holdable cursors:
Date: 2007-02-06 22:49:24
Message-ID: 20070206224924.3EA809FB290@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix an error in the original coding of holdable cursors: PersistHoldablePortal
thought that it didn't have to reposition the underlying tuplestore if the
portal is atEnd. But this is not so, because tuplestores have separate read
and write cursors ... and the read cursor hasn't moved from the start.
This mistake explains bug #2970 from William Zhang.

Note: the coding here is pretty inefficient, but given that no one has noticed
this bug until now, I'd say hardly anyone uses the case where the cursor has
been advanced before being persisted. So maybe it's not worth worrying about.

Modified Files:
--------------
pgsql/src/backend/commands:
portalcmds.c (r1.59 -> r1.60)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/portalcmds.c.diff?r1=1.59&r2=1.60)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-02-06 22:49:30 pgsql: Fix an error in the original coding of holdable cursors:
Previous Message Bruce Momjian 2007-02-06 21:43:06 Re: Re: [COMMITTERS] pgsql: Add documentation for Windows on how to set an environment