| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeremy Haile <jhaile(at)fastmail(dot)fm>, pgsql-general(at)postgresql(dot)org |
| Subject: | Re: Stats collector frozen? |
| Date: | 2007-01-26 11:26:58 |
| Message-ID: | 20070126112658.GE30416@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
On Fri, Jan 26, 2007 at 01:11:00PM +0300, Teodor Sigaev wrote:
> >Apparantly there is a bug lurking somewhere in pgwin32_select(). Because
> >if I put a #undef select right before the select in pgstat.c, the
> >regression tests pass.
>
> May be, problem is related to fixed bug in pgwin32_waitforsinglesocket() ?
> WaitForMultipleObjectsEx might sleep indefinitely while waiting socket to
> write, so, may be there is symmetrical problem with read? Or
> pgwin32_select() is used for waiting write too?
pgwin32_waitforsinglesocket() appears to work fine. And we only use
FD_READ, so it's not affected by your patch from what I can tell.
I've got it passnig tests with select replaced with waitforsinglesocket
- now I just need to implement timeout in that one :-)
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | M.A. Oude Kotte | 2007-01-26 11:41:58 | Rollback using WAL files? |
| Previous Message | Richard Hayward | 2007-01-26 11:06:40 | Installation on Web Server |