| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Win32 WEXITSTATUS too |
| Date: | 2007-01-22 20:10:03 |
| Message-ID: | 200701222010.l0MKA3u28975@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > FYI, here are the URL's I mention in our source code:
>
> > * Wine (URL used in our error messages) -
> > * http://source.winehq.org/source/include/ntstatus.h
> > * Descriptions - http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt
> > * MS SDK - http://www.nologs.com/ntstatus.html
>
> I don't have a problem with mentioning those in a source code comment.
> I question the wisdom of putting any of them in the error message ...
> especially seeing that you haven't even found an "official" Microsoft
> page to link to. None of those look to me like they're stable enough
> to expect to still be there in three or four years.
Agreed. I propose we put the file in src/tools/msvc and link to our CVS
source tree or something.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-01-22 20:10:36 | Re: [HACKERS] Win32 WEXITSTATUS too |
| Previous Message | Magnus Hagander | 2007-01-22 20:09:53 | Re: [HACKERS] Win32 WEXITSTATUS too |