partial pg_regress patch from Magnus

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: partial pg_regress patch from Magnus
Date: 2007-01-18 21:56:01
Message-ID: 20070118215601.GU26080@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hi,

This is a revised partial version of Magnus' patch to pg_regress. The
only thing this patch does is remove the dependency on sed, by having
pg_regress itself generate the .sql and .out files from the .source
files.

The motivator behind this patch is allowing the Visual C++ environment
be in the buildfarm, so while I personally think it's a dumb thing to do
;-) I think the end is worthwhile.

pg_regress now needs to have the source dir in a VPATH build, to know
where to find the source files to process. So a new --srcdir switch was
added.

I tested it in a VPATH and a normal build, and regression test still
pass. This is mostly Magnus' code: I merely stripped out the parts
unrelated to this change, and reworked the code a little. So the
possible bugs are likely mine.

I also changed the Makefile so that the source file list is not
explicit, but rather a $(wildcard) thing. This is because now
pg_regress also gets the file list using a wildcard sort of thing. (The
file list is only used in the "clean" target, so it's likely to get
desynchronized if it has to be updated manually).

Magnus' original patch is in the queue:
http://momjian.us/mhonarc/patches/msg00000.html

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment Content-Type Size
regress.patch text/x-diff 12.9 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-01-19 00:20:11 Re: partial pg_regress patch from Magnus
Previous Message Tom Lane 2007-01-18 21:21:25 WIP: splitting EquivalenceClasses out from PathKeys