Re: [PATCHES] Tablespace for temporary objects and

On Sunday 14 January 2007 23:16, Jaime Casanova wrote:
> On 1/13/07, Albert Cervera Areny <albertca(at)hotpop(dot)com> wrote:
> > It was already possible to set the guc on postgresql.conf when I posted
> > the patch...
>
> ok... fixed... the problem was that this code only let
> num_temp_tablespaces be greater than zero when we are in an
> interactive command (eg. a SET command) but setting the guc from
> postgresql.conf at startup time is not interactive so
> num_temp_tablespaces is zero and when i try to get the first temp
> tablespace to use (MyProcPid % num_temp_tablespaces) causes a floatin
> exception (division by zero).
<snip>
> new patch added, with that piece of code refactored to let
> num_temp_tablespaces get a value greater than zero always that the guc
> is setted, i also add some docs.
>
> the patch passes all 104 regression tests and all my tests as well...
>
> i think the patch is ready to be applied to HEAD, any committer want
> to review it?

Why is this PGC_SUSET? ISTM it should be PGC_USERSET.

--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL