From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | Re: SGML index build fix |
Date: | 2007-01-07 08:57:04 |
Message-ID: | 200701070957.05207.peter_e@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
> The attached patch warns users when they create documentation output
> that has no index, and suggests re-running 'gmake'.
> ! # for some reason $wildcard expands too early, so we use 'test'
$wildcard is expanded whenever you tell it to. What did you write?
> ! @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"
The proper command to run is $(MAKE).
> !
There is a redundant tab on that line.
> + @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"
Probably better to capture that in a variable instead of copying it half a dozen times.
> -e '1a\' -e '<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.2//EN" "http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd">' \
> >$@
> # ' hello Emacs
> + @test -f bookindex.valid || echo "Run 'gmake' again to generate output with a proper index"
When converting to XML, you probably don't want an index because it will
be built differently by the XSLT toolchain. It's not clear what we want
anyway.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2007-01-07 08:57:47 | Re: 8.3 pending patch queue |
Previous Message | Tom Lane | 2007-01-07 08:53:28 | Re: COPY with no WAL, in certain circumstances |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2007-01-07 09:12:30 | Re: [PATCHES] [Fwd: Index Advisor] |
Previous Message | Tom Lane | 2007-01-07 08:53:28 | Re: COPY with no WAL, in certain circumstances |