Re: [HACKERS] [BUGS] BUG #2846: inconsistent and

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Roman Kononov <kononov195-pgsql(at)yahoo(dot)com>
Subject: Re: [HACKERS] [BUGS] BUG #2846: inconsistent and
Date: 2006-12-30 18:53:25
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > OK, are you saying that there is a signal we are ignoring for
> > overflow/underflow, or that we should just silently overflow/underflow
> > and not throw an error?
> Silent underflow is fine with me; it's the norm in most all float
> implementations and won't surprise anyone. For overflow I'm OK with
> either returning infinity or throwing an error --- but if an error,
> it should only be about inf-out-with-non-inf-in, not comparisons to any
> artificial MAX/MIN values.

OK, I am happy to remove the MIN/MAX comparisons. Those were in the
original code.

The attached, updated patch creates a single CHECKFLOATVAL() macro that
does the overflow/underflow comparisons and throws an error. This also
reduces the isinf() calls. Should I be concerned we are now duplicating
the error text in all call sites?

Regression wording modified now that float4/float8 checks are merged. I
haven't update the platform-specific float* expected files yet, but will
on commit.

Bruce Momjian bruce(at)momjian(dot)us

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/pgpatches/float text/x-diff 39.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-12-30 19:05:12 Re: Logging temp file useage ... a little advice
Previous Message Bruce Momjian 2006-12-30 18:44:58 Re: TODO: GNU TLS

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-12-30 21:23:02 Re: [HACKERS] Bundle of patches
Previous Message Jim C. Nasby 2006-12-30 04:46:27 Re: column ordering, was Re: [PATCHES] Enums patch v2