Re: pg_restore fails with a custom backup file

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Zeugswetter Andreas ADI SD <ZeugswetterA(at)spardat(dot)at>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Yoshiyuki Asaba <y-asaba(at)sraoss(dot)co(dot)jp>, z-saito(at)guitar(dot)ocn(dot)ne(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_restore fails with a custom backup file
Date: 2006-12-29 16:30:48
Message-ID: 20061229163048.GA25594@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 19, 2006 at 04:58:22PM +0100, Zeugswetter Andreas ADI SD wrote:
>
> > > > > MinGW has fseeko64 and ftello64 with off64_t.
> > > > >
> > > >
> > > > Maybe we need separate macros for MSVC and MinGW. Given the other
> > >
> > > You mean something quick and dirty like this ? That would work.
> >
> > Yes, except does that actually work? If so you found the place in the
> > headers to stick it without breaking things that I couldn't find ;-)
>
> Compiles clean without warnings on MinGW, but not tested, sorry also no
> time.

Does not compile on my MinGW - errors in the system headers (unistd.h,
io.h) due to changing the argument format for chsize(). The change of
off_t propagated into parts of the system headers, thus chaos was
ensured.

I still think we need to use a pgoff_t. Will look at combining these two
approaches.

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2006-12-29 16:37:12 Re: TODO: GNU TLS
Previous Message Tom Lane 2006-12-29 16:28:12 Re: What's the difference between postgresql.conf.sample and postgresql.conf.sample.orig